gayanvirajith / harmony

A responsive Jekyll theme.
http://gayan.me/harmony
Other
224 stars 204 forks source link

Fix end div tag issue for multiple years in blog archive #21

Closed taher435 closed 7 years ago

taher435 commented 7 years ago

When we have blog posts across multiple years, then, for the first year if we have more than one blog posts, there is rogue </div> tag which does not get rendered properly.

Reason: For the last loop iteration, the code never goes back to the

{% unless forloop.first %}</ul>{% endunless %}

which is responsible for closing the ul tag. As a reason, the generator is not able to render the close div tag properly.

Screenshot from live blog -

Before fix

image

After fix

image

tkovs commented 7 years ago

good

gayanvirajith commented 7 years ago

merged thanks to @taher435