gaynorr / AlphaSimR

R package for breeding program simulations
https://gaynorr.github.io/AlphaSimR/
Other
42 stars 18 forks source link

Improved pedigreeCross #79

Open gaynorr opened 2 years ago

gaynorr commented 2 years ago

Is your feature request related to a problem? Please describe. The functionality of pedigreeCross is limited by that fact that it only handles Pop class objects after simulations start and cannot handle MapPop objects prior to the start of a simulation.

The pedigree checking of the function fails to handle some edge cases when using the matchID=TRUE option. The function fails to recognize cases where an existing id is being replaced by a new individual. The function sometimes fails without an appropriate warnings when an incomplete pedigree is supplied.

Describe the solution you'd like The function should be able to take a MapPop as an option.

The pedigree checking code needs to be revisited and more detailed errors and warning should be reported.

The function should be able to use individuals in the input population as founders without expressly listing them as founders in the pedigree when using the matchID=TRUE option.