search

gaz561 / tab

Groundhog Operating System
0 stars 1 forks source link

Fix printing of prompt on login. #2

Closed technomancy closed 1 year ago

technomancy commented 2 years ago

Previously the prompt string was part of the welcome message, but the welcome message got printed with a newline on the end, so the prompt wasn't on the final line.

This change removes it from the message and uses a different method to determine whether each loop should print the prompt; the state is stored in the client table instead of in a local var so that the welcome message function can set it.

Even tho I have commit access and the ability to push to the main branch, I'll stick with pull requests on branches for my contributions unless they're very simple or it's something we discussed ahead of time; I don't want to make any changes that you aren't aware of. Unless it becomes annoying; if so let me know and I can tone it down. =)

emsenn commented 1 year ago

I am very bad at github! I'm p sure i implemented this right, even tho everything got moved around. (I added a "set the variable to nil after we've sent the prompt because it's... traditional? to send the prompt in response to input, not as an appendix to output, with MUDs. Hadn't ever thought about how odd that is until just now!