search

gazaskygeeks / mpcc-assistant

Platform to consolidate info/docs from visiting GSG mentors
https://mpcc-assistant.herokuapp.com/
0 stars 0 forks source link

Include navbar directly #108

Open tomduggan85 opened 6 years ago

tomduggan85 commented 6 years ago

I think here, you could just include the navbar component itself (i.e. instead of wrapping it in a Route component.

https://github.com/gazaskygeeks/mpcc-assistant/blob/6c0d9f5c76bfbdaaca06b7ae96da798f17b20cd3/src/client/components/App.js#L23

sultanassi95 commented 6 years ago

https://github.com/gazaskygeeks/mpcc-assistant/blob/6c0d9f5c76bfbdaaca06b7ae96da798f17b20cd3/src/client/components/navbar/Navbar.js#L45

This is the why I had to do it, I know for sure that this(if ROUTE) is not the best practice to choose whether the navbar to be displayed in a specific route or not. but, there is no proper login validation for cookies or tokens in our app. You are free to share IDEAS :smile: when/if you can :+1:

Thanks Tom!