Suppress Ruby 2.7's warning about keyword arguments

gazay / gon

Your Rails variables in your JS

MIT License

3.05k stars 185 forks source link

Suppress Ruby 2.7's warning about keyword arguments #260

Closed oieioi closed 4 years ago

oieioi commented 4 years ago

Suppress Ruby 2.7's warning about keyword arguments.

cf. https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/

gazay commented 4 years ago

Thank you! :octopus:

thbar commented 4 years ago

@oieioi thanks for the patch!

@gazay this fixes the warnings on my side too. A new release with that (for Ruby 2.7 support) would be nice if you have the bandwidth for that! Many thanks.

jcw- commented 4 years ago

@gazay +1 for a release with this fix when you have a chance, much appreciated!

gazay commented 4 years ago

@thbar @jcw- hey! That's strange that you still have them. Can you please check if they are present in new v6.4.0?

jcw- commented 4 years ago

oh! i was looking at GH releases (which didn't have 6.4.0 listed until 15 minutes ago), but it was actually on RubyGems since shortly the previous comment on this thread, i suspect it's all good and i just need to upgrade, sorry I should have also looked on RubyGems - thanks!

gazay commented 4 years ago

Yeah, I forgot to push tag with new version. Sorry about that :)