search

gazay / lysa-old

Clone of https://github.com/learnyou/lysa
Other
3 stars 1 forks source link

Merge the English and Russian versions? #5

Closed pharpend closed 9 years ago

pharpend commented 9 years ago

Hi, main-ish author here.

It occurs to me that, in the future, there will likely be original content added to the Russian version of LYSA, which we'll want to translate into English. There may also be a French version sometime soon. With that in mind, it will quickly be a pain to sync everything between the various repositories.

So, let's put everything in one repo, but with different directories for different languages. That is,

lysa/
    README.md
    LICENSE
    docs/
    en/
        README.md
        appendices/
        bibliographies/
        ...
    ru/
        README.md
        appendices/
        bibliographies/
        ...
    fr/
        README.md
        appendices/
        bibliographies/
        ...

I wouldn't want multiple people having commit access to the central repository, because that gets ugly very quickly, with politics and such. I would also not want to have 3 different active branches in the central repository, because that would inevitably cause politics. (Trust me, I tried this with https://github.com/learnmath/lysa . Politics everywhere.) I think the best option is for y'all to keep your own repo, and then we pull-request them periodically.

So, to summarize, here's what I'm proposing:

Is that alright with everyone?

gazay commented 9 years ago

Yep, it's ok for me. Scheme is the same as in https://github.com/ruby/www.ruby-lang.org. But don't you still think that better be working on original book in github? Here much more people who can find and help with the book, also here much more done for easy collaboration. Syntax highlighting, transparent commenting on PR lines, PRs. I think you can win more (stars, pr, small orphographic fixes etc) than lose if you move repo to github.com/lysa/lysa for example. For example I found small mistake (as I think it is a mistake), but it is so small and I was uncomfortable to add my ssh key to gitlab, dig into gitlab's interface, learn how to make PR there just for this small fix. I think as most of IT people now here it will be same story for them.

pharpend commented 9 years ago

Yeah, you are right, unfortunately.

pharpend commented 9 years ago

Okay, I merged them at https://github.com/learnyou/lysa . Pull from the master branch (I promise it won't delete any of your stuff).

gazay commented 9 years ago

Great!