search

gazayas / masamune-ast

A covenience wrapper around Prism, a Ruby source code parser
MIT License
13 stars 1 forks source link

Move pry require to tests #53

Closed kaspth closed 1 year ago

kaspth commented 1 year ago

While I was working on https://github.com/bullet-train-co/bullet_train-core/pull/597, I found that I had to add:

gem "masamune-ast" # TODO: Remove the bullet_train.gemspec dependency to super_scaffolding's gemspec.
gem "pry" # TODO: Remove masumune's internal `require "pry"` call.

Ref: https://github.com/bullet-train-co/bullet_train-core/pull/597/files#diff-68cca28f9c2368a9481c0ade06f7da3d4c5c13dd81597e53201ece7c00c8fa90R14-R15

Where masamune expected client apps to have pry included in their Gemfiles, which everyone might not.

Since pry is mostly a dev-dependency, I've moved the require to the test_helper.rb

gazayas commented 1 year ago

Oof, good call, I hadn't run into that issue when testing so I wasn't aware of it. I'll merge and see if I can release a new version here soon.