search

gazbert / bxbot

A simple Bitcoin trading bot written in Java.
MIT License
779 stars 275 forks source link

build process has ~ 2 tests that fail #48

Closed datasmithtech closed 7 years ago

datasmithtech commented 7 years ago

i ran the build , and i noticed a couple of tests failed bxbot-xml-datastore:test

Tests com.gazbert.bxbot.datastore.config.engine 3 1 0 0.660s 66% com.gazbert.bxbot.datastore.config.exchange

Class com.gazbert.bxbot.datastore.config.engine.TestEngineConfigurationManagement 3 1 0 0.660s 66% com.gazbert.bxbot.datastore.config.exchange.TestExchangeConfigurationManagement

i am running on windows using latest stable release

gazbert commented 7 years ago

Hi Larry thanks for letting me know. I mostly develop on linux/osx, so could be an OS thing - will take a look on my work Windows machine on Monday. Guess you can @ignore the tests to get a build in the meantime.

Will keep you posted.

-- sent from my phone --

On 25 Feb 2017 11:42 a.m., "Larry Smith" notifications@github.com wrote:

i ran the build , and i noticed a couple of tests failed bxbot-xml-datastore:test

Tests com.gazbert.bxbot.datastore.config.engine 3 1 0 0.660s 66% com.gazbert.bxbot.datastore.config.exchange

Class com.gazbert.bxbot.datastore.config.engine.TestEngineConfigurationManagement 3 1 0 0.660s 66% com.gazbert.bxbot.datastore.config.exchange.TestExchangeConfigurationManag ement

i am running on windows using latest stable release

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gazbert/bxbot/issues/48, or mute the thread https://github.com/notifications/unsubscribe-auth/AGM1tnMmw92B6uw3TLNMJqFO-Pg88_iFks5rgBOwgaJpZM4ML_SL .

gazbert commented 7 years ago

Added fix to close config loading/saving input/output streams. The bot was getting away with this on Linux/OSX, but running the xml-datastore unit tests on Windows highlighted the issue - thanks to @datasmithtech for spotting this.