search

gazbert / bxbot

A simple Bitcoin trading bot written in Java.
MIT License
824 stars 280 forks source link

Failing Test at HEAD #77

Closed KosherBacon closed 6 years ago

KosherBacon commented 6 years ago

Wanted to begin trying this out. when I downloaded from HEAD and ran the gradlew clean build command the testEngineExecutesNextTradeCyclesAfterReceivingExchangeNetworkException test fails consistently for me. Fails here.

I'm running this on a Windows 10 machine. I got the same failure on a macOS machine as well.

gazbert commented 6 years ago

Sounds like a timing issue in the wait for the bot to stop on diff architectures. Have you tried increasing the Thread.sleep(1000) value? Try pushing it up to 2000/3000.

Ideally, these unit tests need tweaking to wait in a loop for the bot to shutdown... I'll stick it on my list.

Not had timing issues to date on Debian, Ubuntu, and my Macbook Pro (High Sierra) - thank for spotting this.

KosherBacon commented 6 years ago

2000 worked for me.

gazbert commented 6 years ago

Done. Ready for next release.

gazbert commented 6 years ago

Released.