search

gazebo-tooling / action-gz-ci

MIT License
5 stars 4 forks source link

Script hooks #4

Closed chapulina closed 4 years ago

chapulina commented 4 years ago

Closes #1 and also closes #2.

Two of the hooks are being used on https://github.com/osrf/sdformat/pull/266

scpeters commented 4 years ago

instead of passing the names of these scripts as variables, what if we just hard-coded the names of expected scripts (like .github/ci-bionic/after_make.sh) and then check if that file exists and try to call it if so

I think it's slightly simpler that way

chapulina commented 4 years ago

instead of passing the names of these scripts as variables, what if we just hard-coded the names of expected scripts

I just noticed this comment. Yeah I think it's a good idea, but now a lot of PRs using that have been merged. So I'll just leave it as is for now and ticketed #8 so we can keep it in mind for the next pass.