gazebo-tooling / release-tools

8 stars 9 forks source link

Move brew ci-pr_any- to gazebo_libs #1054

Closed j-rivero closed 8 months ago

j-rivero commented 8 months ago

Note: easier to check without whitespaces https://github.com/gazebo-tooling/release-tools/pull/1054/files?w=1

Change brew ci-pr_any jobs to be created by gazebo_libs.dsl using gz-collections.yaml.

Steps:

j-rivero commented 8 months ago

CI looks reasonable to me:

Only in /tmp/pr_xml_configuration: gz_cmake-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: gz_common-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: gz_fuel_tools-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: gz_gui-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: gz_launch-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: gz_math-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: gz_msgs-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: gz_physics-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: gz_plugin-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: gz_rendering-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: gz_sensors-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: gz_sim-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: gz_tools-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: gz_transport-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: gz_utils-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: ign_cmake-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: ign_common-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: ign_fuel_tools-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: ign_gazebo-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: ign_gui-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: ign_launch-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: ign_math-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: ign_msgs-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: ign_physics-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: ign_plugin-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: ign_rendering-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: ign_sensors-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: ign_tools-ci-pr_any-homebrew-amd64.xml
Only in /tmp/pr_xml_configuration: ign_transport-ci-pr_any-homebrew-amd64.xml
... (changes to make current jobs fake) ...

And changes in the jobs generated with respect to the previous original ones, looks fine to me:

  --- ignition_math-ci-pr_any-homebrew-amd64.xml  2023-11-02 18:52:46.069527620 +0100                                                                                                                                                                                           
  +++ /tmp/new/gz_math-ci-pr_any-homebrew-amd64.xml       2023-11-02 18:46:41.537239139 +0100                                                                                                                                                                                   
  @@ -93,15 +93,13 @@                                                                                                                                                                                                                                                           
           <hudson.tasks.Shell>                                                                                                                                                                                                                                                 
               <command>#!/bin/bash -xe                                                                                                                                                                                                                                         

  -software_name="gz-math"                                                                                                                                                                                                                                                      
  -[[ math == 'gazebo' ]] &amp;&amp; software_name="gz-sim"                                                                                                                                                                                                                     
  -/bin/bash -xe "./scripts/jenkins-scripts/lib/project-default-devel-homebrew-amd64.bash" "${software_name}"                                                                                                                                                                   
  +/bin/bash -xe "./scripts/jenkins-scripts/lib/project-default-devel-homebrew-amd64.bash" "gz-math"                                                                                                                                                                            
   </command>                                                                                                                                                                                                                                                                   
           </hudson.tasks.Shell>                                                                                                                                                                                                                                                
       </builders>                                                                                                                                                                                                                                                              
       <publishers>                                                                                                                                                                                                                                                             
           <hudson.plugins.emailext.ExtendedEmailPublisher>                                                                                                                                                                                                                     
  -            <recipientList>$DEFAULT_RECIPIENTS, caguero@osrfoundation.org</recipientList>                                                                                                                                                                                    
  +            <recipientList>$DEFAULT_RECIPIENTS</recipientList>                                                                                                                                                                                                               
               <configuredTriggers>                                                                                                                                                                                                                                             
                   <hudson.plugins.emailext.plugins.trigger.FailureTrigger>                                                                                                                                                                                                     
                       <email>                                                                                                                                                                                                                                                  
  @@ -365,7 +363,7 @@                                                                                                                                                                                                                                                           
           <gitTool>Default</gitTool>                                                                                                                                                                                                           
           <extensions>                                                                                                                                                                                                                         
               <hudson.plugins.git.extensions.impl.RelativeTargetDirectory>                                                                                                                                                                                                     
  -                <relativeTargetDir>ign-math</relativeTargetDir>                                                                                                                                                                                                              
  +                <relativeTargetDir>gz-math</relativeTargetDir>                                                                                                                                                                                                               
               </hudson.plugins.git.extensions.impl.RelativeTargetDirectory>                                                                                                                                                                                                    
           </extensions>                                                                                                                                                                                                                                                        
           <browser class='hudson.plugins.git.browser.GithubWeb'>     
j-rivero commented 8 months ago

Merging to follow the migration in new PRs