Closed scpeters closed 10 months ago
I noticed the following failed CI job and made a few fixes after some debugging:
That first failure has the following error:
++ brew cleanup --prune-prefix ./scripts/jenkins-scripts/lib/_homebrew_cleanup.bash: line 34: brew: command not found
The fix in https://github.com/gazebo-tooling/release-tools/commit/8e852017192e5f4c93f07a3107f60f72bcc981bc is to use ${BREW_BINARY} to match the rest of the script.
${BREW_BINARY}
After that I saw a brew doctor complaint about sbin not being in the PATH:
brew doctor
sbin
PATH
Warning: Homebrew's "sbin" was not found in your PATH but you have installed formulae that put executables in /usr/local/sbin. Consider setting your PATH for example like so: echo 'export PATH="/usr/local/sbin:$PATH"' >> ~/.zshrc
The fix is in https://github.com/gazebo-tooling/release-tools/commit/115c708f346ec373b38eadc96f525b57bb2645ee, copied from https://github.com/gazebo-tooling/release-tools/pull/931.
I then made a change in https://github.com/gazebo-tooling/release-tools/commit/70c04c491bf3d86fcb413273f50501074d6fee5d and https://github.com/gazebo-tooling/release-tools/commit/46f55b9b046c5a524d702fdc004d8039b5c53226 to use a local copy of the script in CI, and after it passed, I reverted to curling the script and followed the recommendation to get it from https://get.gazebosim.org
curl
https://build.osrfoundation.org/view/ign-citadel/job/gazebo-install-one_liner-homebrew-amd64/2963/
The CI job should be fixed once this is merged.
I noticed the following failed CI job and made a few fixes after some debugging:
That first failure has the following error:
The fix in https://github.com/gazebo-tooling/release-tools/commit/8e852017192e5f4c93f07a3107f60f72bcc981bc is to use
${BREW_BINARY}to match the rest of the script.After that I saw a
brew doctorcomplaint aboutsbinnot being in thePATH:The fix is in https://github.com/gazebo-tooling/release-tools/commit/115c708f346ec373b38eadc96f525b57bb2645ee, copied from https://github.com/gazebo-tooling/release-tools/pull/931.
I then made a change in https://github.com/gazebo-tooling/release-tools/commit/70c04c491bf3d86fcb413273f50501074d6fee5d and https://github.com/gazebo-tooling/release-tools/commit/46f55b9b046c5a524d702fdc004d8039b5c53226 to use a local copy of the script in CI, and after it passed, I reverted to
curling the script and followed the recommendation to get it from https://get.gazebosim.orgThe CI job should be fixed once this is merged.