search

gazebo-tooling / release-tools

8 stars 9 forks source link

Jenkins views: fix some job names #1079

Closed scpeters closed 7 months ago

scpeters commented 7 months ago

Changes some ignition_gazebo to gz_sim and other ignition_ to gz_.

UPDATE:

I've added many more changes since that first commit. There are still some issues:

j-rivero commented 7 months ago

One of the reasons to implement the issue #1010 is to be able to generate all the collections set of jobs programmatically and do not hardcode values anymore. The implement still lacks of the -install- jobs to be able to replace the views in this PR but can provide all the ci-branch related job names in a log file together with the type of job and the collection. This is the current log https://gist.github.com/j-rivero/7c3468bae2e9ee39497131715c6add82.

It is easy to alpha-sort + grep that generated log file so two options:

Whatever you prefer @scpeters

scpeters commented 7 months ago

One of the reasons to implement the issue #1010 is to be able to generate all the collections set of jobs programmatically and do not hardcode values anymore.

ooh, I love this! 💯

The implement still lacks of the -install- jobs to be able to replace the views in this PR but can provide all the ci-branch related job names in a log file together with the type of job and the collection. This is the current log https://gist.github.com/j-rivero/7c3468bae2e9ee39497131715c6add82.

It is easy to alpha-sort + grep that generated log file so two options:

  • Just copy/paste the alpha-order of all ci-branch and move the -install- jobs after. It will change current order and make things more difficult to human-read but would be great for completeness.
  • We leave the PR as it is and wait unlit the -install- jobs generation to replace it completely.

I think I will paste the values from your gist into this branch just to get working views again, and then we can deprecate the explicit list for the auto-generated views

scpeters commented 7 months ago

to the best of my ability, I've manually updated the job names to match the gist that @j-rivero listed in https://github.com/gazebo-tooling/release-tools/pull/1079#issuecomment-1821544221. So this currently matches the names generated by our DSL jobs. We can discuss what we would like them to be named and work on auto-generating the views, but I think this PR could be merged as a short-term fix for the views

j-rivero commented 7 months ago

We can discuss what we would like them to be named and work on auto-generating the views, but I think this PR could be merged as a short-term fix for the views

Agree. LGTM