gazebo-tooling / release-tools

8 stars 9 forks source link

Do not exclude gz-common from focal ci_configs #1094

Closed azeey closed 6 months ago

azeey commented 6 months ago

ign-common4 (Fortress) is configured to run on focal, but we were excluding the abichecker from the focal ci_configs.

https://build.osrfoundation.org/job/gz_common-abichecker-any_to_any-ubuntu-jammy-amd64/ only triggers on gz-common5.

j-rivero commented 6 months ago

In fact, since we moved Citadel from Bionic to Focal we also need to remove the other exclusions:

        - gz-math
        - gz-plugin
        - gz-utils

This is going to have the side effect of making the branches shared by Garden (ci_config is focal) and Harmonic(ci_config is jammy) to duplicate the abichecker jobs. I'll open an issue and think the best way of dealing with this.

azeey commented 6 months ago

In fact, since we moved Citadel from Bionic to Focal we also need to remove the other exclusions:

        - gz-math
        - gz-plugin
        - gz-utils

This is going to have the side effect of making the branches shared by Garden (ci_config is focal) and Harmonic(ci_config is jammy) to duplicate the abichecker jobs. I'll open an issue and think the best way of dealing with this.

Thanks for the fix!

azeey commented 6 months ago

Can we merge this before we find a solution to #1095 to unblock https://github.com/gazebosim/gz-common/pull/559?

j-rivero commented 6 months ago

Can we merge this before we find a solution to #1095 to unblock gazebosim/gz-common#559?

sure!