Closed claraberendsen closed 7 months ago
Blast545
commented
7 months ago Just for the sake of double checking it doesn't break the build where the problem was found, can you run a job in https://build.osrfoundation.org/job/gz_sim-abichecker-any_to_any-ubuntu-jammy-amd64/build?delay=0sec with this fix branch?
Approving on conditional that green CI is checked with this branch.
j-rivero
commented
7 months ago Just for the sake of double checking it doesn't break the build where the problem was found, can you run a job in https://build.osrfoundation.org/job/gz_sim-abichecker-any_to_any-ubuntu-jammy-amd64/build?delay=0sec with this fix branch?
Clarifying: to avoid the problem of having two conflicting package installation processes we should remove all of the packages in this call to be able to get rid of it. To do so, the provisioning should be patches to install all the packages installed by NEEDED_HOST_PACKAGES. I did it in https://github.com/osrf/osrf_jenkins_agent/pull/43.
To completely kill the apt-get install, we would need to merge the PR in provisioning and re-generate new AIMs.
claraberendsen
commented
7 months ago To completely kill the apt-get install, we would need to merge the PR in provisioning and re-generate new AIMs.
@j-rivero I agree on unifying everything on provisioning. I will update this PR to remove the apt-get call completely and proceed to review and deploy the related one you opened before merging this one.
claraberendsen
commented
7 months ago @j-rivero re-requesting a review here since we changed approach.
j-rivero
commented
7 months ago @j-rivero re-requesting a review here since we changed approach.
Can not merge before we re-generate the AMIs of the agents.
Description
There were some issues with unattended upgrades making builds fail (See). After some research it seems this is due to release-tools installing packages that are already provisioned when the image for the agents is built. This PR removes all dependencies that are installed through this mechanism.