gazebo-tooling / release-tools

8 stars 9 forks source link

Avoid duplicate abichecker in Fortress/Harmonic #1126

Closed j-rivero closed 3 months ago

j-rivero commented 3 months ago

Fixes: #1095

The fact of having two abichecker in the PRs can be workaround by defining a new ci_configuration (focal_exclude_harmonic_abi_dups) which clones focal for Garden but exclude the libraries also present in Harmonic from having an abichecker.

The PR also reverts : "Disable DSL check for duplicate abicheckers (#1099)" so the dsl_check is in place again.

j-rivero commented 3 months ago
Files /tmp/current_xml_configuration/gz_cmake-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_cmake-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_common-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_common-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_common-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_common-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_fuel_tools-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_fuel_tools-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_fuel_tools-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_fuel_tools-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_gui-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_gui-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_gui-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_gui-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_launch-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_launch-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_launch-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_launch-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_math-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_math-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_math-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_math-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_msgs-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_msgs-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_msgs-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_msgs-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_physics-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_physics-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_physics-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_physics-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_plugin-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_plugin-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_plugin-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_plugin-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_rendering-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_rendering-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_rendering-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_rendering-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_sensors-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_sensors-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_sensors-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_sensors-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_sim-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_sim-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_sim-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_sim-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_tools-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_tools-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_transport-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_transport-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_transport-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_transport-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_utils-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_utils-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_utils-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_utils-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/sdformat-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/sdformat-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/sdformat-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/sdformat-ci-pr_any-focal-amd64.xml differ

This is breaking things that are unrelated to the change :(