search

gazebo-tooling / release-tools

8 stars 9 forks source link

Inject test output into junit files generated by gtest #1130

Closed azeey closed 2 months ago

azeey commented 2 months ago

Fixes https://github.com/gazebosim/gz-cmake/issues/240

Example: https://build.osrfoundation.org/view/asan/job/gz_common-ci_asan-gz-common5-jammy-amd64/32/testReport/(root)/INTEGRATION_encoder_timing/test_ran/

azeey commented 2 months ago

From my local tests, if ctest doesn't have --output-junit, it just simply ignores the flag and won't generate anything. The Python script will just not run in that case since we check for the output .xml file before running it.

j-rivero commented 2 months ago

From my local tests, if ctest doesn't have --output-junit, it just simply ignores the flag and won't generate anything. The Python script will just not run in that case since we check for the output .xml file before running it.

that is totally true. I was checking first with cmake instead of ctest and it fails hard if the argument does not exist.

j-rivero commented 2 months ago

@Crola1702 @Blast545 @claraberendsen we are ready to merge this one. The side effect of it is that we can see new failures raised to the jenkins builds results as a consequence of raising the errors from CTest to the google-test files that are the ones scanned by Jenkins. I don't think that we have ASAN builds under the scope of the standard buildfarm report which are the ones mostly affected but some others could appear. New errors are probably valid and need to be triggered.