gazebo-tooling / release-tools

8 stars 9 forks source link

Make CI checks required #398

Open chapulina opened 3 years ago

chapulina commented 3 years ago

This issue keeps track of which CI checks are marked as required for each branch on each library.

Only build checks are listed here, because checks like DCO are already required for all libraries.

Required checks are those which must be green before merging a PR. The ultimate goal is to have all checks required, but we need to address known flakes and failures before requiring them.

This list is expected to be dynamic, and we may have regressions that force us to unrequire checks when new issues are introduced. For example, upstream changes in homebrew introduced warnings into our ign-common macOS builds, see https://github.com/ignitionrobotics/ign-common/issues/203.

This list only covers release branches that are part of Ignition collections, so it does not cover branches that are still supported because they're Gazebo 9 dependencies.


ign-cmake

All checked * Release branches - [x] GitHub actions Bionic - [x] GitHub actions Focal - [x] GitHub actions Jammy - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows * `main` - [x] GitHub actions Focal - [x] GitHub actions Jammy - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows

ign-common

All checked * `ign-common3` - [x] GitHub actions Bionic - [x] GitHub actions Focal - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows - [x] ABI checker * `ign-common[4-9]` - [x] GitHub actions Bionic (option not showing up) - [x] GitHub actions Focal - [x] GitHub actions Jammy - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows - [x] ABI checker * `gz-common[0-9]` - [x] GitHub actions Focal - [x] GitHub actions Jammy - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows - [x] ABI checker * `main` - [x] GitHub actions Noble - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows

ign-fuel-tools

ign-gazebo

ign-gui

ign-launch

ign-math

All checked * Release branches - [x] GitHub actions Bionic - [x] GitHub actions Focal - [x] GitHub actions Jammy - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows - [x] ABI checker * `main` - [x] GitHub actions Focal - [x] GitHub actions Jammy - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows

ign-msgs

All checked * `ign-msgs[0-1]` - [x] GitHub actions Bionic - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows - [x] ABI checker * `ign-msgs[2-5]` - [x] GitHub actions Bionic - [x] GitHub actions Focal - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows - [x] ABI checker * `ign-msgs[6-9]` - [x] GitHub actions Focal - [x] GitHub actions Jammy - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows - [x] ABI checker * `main` - [x] GitHub actions Focal - [x] GitHub actions Jammy - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows

ign-physics

ign-plugin

All checked * Release branches - [x] GitHub actions Bionic - [x] GitHub actions Focal - [x] GitHub actions Jammy - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows - [x] ABI checker * `main` - [x] GitHub actions Focal - [x] GitHub actions Jammy - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows

ign-rendering

ign-sensors

ign-tools

All checked * Release branches - [x] GitHub actions Bionic - [x] GitHub actions Focal - [x] GitHub actions Jammy - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows * `main` - [x] GitHub actions Focal - [x] GitHub actions Jammy - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows

ign-transport

ign-utils

All checked * Release branches - [x] GitHub actions Bionic - [x] GitHub actions Focal - [x] GitHub actions Jammy - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows - [ ] ABI checker (option not showing up) * `main` - [x] GitHub actions Focal - [x] GitHub actions Jammy - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows

sdformat

All checked * `sdf[0-9]` - [x] GitHub actions Bionic - [x] GitHub actions Focal - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows - [x] ABI checker * `sdf[0-9][0-9]` - [x] GitHub actions Focal - [x] GitHub actions Jammy - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows - [x] ABI checker * `main` - [x] GitHub actions Focal - [x] GitHub actions Jammy - [x] Jenkins Homebrew - [x] Jenkins Ubuntu - [x] Jenkins Windows
scpeters commented 3 years ago

I just checked the boxes to indicate the current configuration of ign-physics

chapulina commented 3 years ago

I just checked the boxes to indicate the current configuration of ign-physics

Thanks, I thought I had done it for all of them, but the GitHub UI kept acting wreird

scpeters commented 3 years ago

I think ign-common main on windows is clean and we could mark it as required (cc @mjcarroll )

mjcarroll commented 3 years ago

I think ign-common main on windows is clean and we could mark it as required (cc @mjcarroll )

Good with me.

chapulina commented 2 years ago

I removed the Ubuntu Bionic requirement for all main branches and updated the list above.

chapulina commented 2 years ago

I just did another pass over all the checks for all libraries and updated their status. I also made sure that Bionic checks are only required up to Fortress, and Jammy checks only from Fortress.

mjcarroll commented 2 years ago

Jenkins Homebrew warning: 'channels' is deprecated

Closed via https://github.com/gazebosim/gz-common/pull/416