Added husky and lint - Githubissues

gazebo-tooling / setup-gazebo

GitHub Action to set up Gazebo environment

https://github.com/marketplace/actions/setup-gazebo-environment

Apache License 2.0

3 stars 1 forks source link

Added husky and lint #9

Closed sauk2 closed 3 months ago

sauk2 commented 3 months ago

Closes #8. Closes #6.

Summary

Taking reference from setup-ros, added lint-staged to run through husky pre-commit.
Added run instructions for lint in package.json.
Added a workflow to check PRs.

sauk2 commented 3 months ago

Changes looks right to me. However we need a way to run the linter on PR changes to be sure that we are complaining with it? Is it being run somewhere now in our workflow? If not, maybe adding something like https://github.com/ros-tooling/setup-ros/blob/master/.github/workflows/pr.yml can help to check that the linter is in action.

Great idea! Added a workflow to check PRs. All checks pass :tada: