gazebosim / docs

High-level Gazebo documentation that gets published to https://gazebosim.org/docs/
https://gazebosim.org/docs
44 stars 81 forks source link

Introduce how to use unofficial ros_gz combinations for Garden/Humble #362

Closed j-rivero closed 10 months ago

j-rivero commented 12 months ago

The PR adds some documentation to the ROS installation document to cover the new option of the so-called "Unofficial wrappers" binary packages for the Garden/Humble combination. Two main parts in the changes:

  1. Explain the option of using non ROS official packages together with the build from source and the cons of using them.
  2. Modify the Garden/Humble instructions to cover this new option.
azeey commented 11 months ago

I'd also suggest we drop the "unofficial" part. I'm not sure what that buys us.

j-rivero commented 11 months ago

Does "official" mean the packages on packages.ros.org, and "non-official" means the packages on packages.osrfoundation.org? Somewhere in here, it should directly say what these terms mean.

This is correct, but "unofficial" also means that these packages are out of the official ROS maintenance for packages (out of the buildfarm) which have some implications: packages are not automatically rebuild when dependencies change (implicit risk of ABI breakages), releases are not in sync with the sources ,etc.

I'd also suggest we drop the "unofficial" part. I'm not sure what that buys us.

Same than above, not the usual ROS maintenance/building features that someone expects from ROS packages.

j-rivero commented 11 months ago

Thanks for the reviews. I change the pointers to osrfoundation.org by the repository name and all the "unofficial" words that I found to use "non official".

quarkytale commented 11 months ago

Would using "unsupported" or the likes of it, serve better than the official/unofficial phrase?

j-rivero commented 11 months ago

Would using "unsupported" or the likes of it, serve better than the official/unofficial phrase?

Umm, may help to understand that the packages are not typical maintained ROS packages but I assume that we want to provide support on fixing, debugging and updating these packages so it might drive to a confusion.

j-rivero commented 10 months ago

@kscottz could you please give a quick look so we all are good with the final changes?