gazebosim / docs

High-level Gazebo documentation that gets published to https://gazebosim.org/docs/
https://gazebosim.org/docs
48 stars 117 forks source link

Remove use of enable_gcc8 script to fix focal builds #389

Closed azeey closed 1 year ago

azeey commented 1 year ago

🦟 Bug fix

Summary

Focal based docker containers were failing to build documentation because running enable_gcc8.sh script fails.

Try using:

docker build -t gz-fortress-docs -f Dockerfile.fortress --build-arg GZ_VERSION_PASSWORD=foo --build-arg GZ_VERSION_DATE=5 --build-arg AWS_ACCESS_KEY_ID=foo --build-arg AWS_SECRET_ACCESS_KEY=foo .

and you'd get

STEP 12/28: RUN scripts/enable_gcc8.sh

sudo apt-get install g++-8
Reading package lists...
Building dependency tree...
Reading state information...
The following additional packages will be installed:
  cpp-8 gcc-8 gcc-8-base libgcc-8-dev libmpx2 libstdc++-8-dev
Suggested packages:
  gcc-8-locales g++-8-multilib gcc-8-doc gcc-8-multilib libstdc++-8-doc
The following NEW packages will be installed:
  cpp-8 g++-8 gcc-8 gcc-8-base libgcc-8-dev libmpx2 libstdc++-8-dev
0 upgraded, 7 newly installed, 0 to remove and 0 not upgraded.
Need to get 32.8 MB of archives.
After this operation, 115 MB of additional disk space will be used.
Do you want to continue? [Y/n] Abort.
Error: building at STEP "RUN scripts/enable_gcc8.sh": while running runtime: exit status 1

It's possible to fix enable_gcc8.sh itself to avoid this error, but that script is actually not needed on Focal since gcc-9 is the default there.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

πŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”Έ