gazebosim / docs

High-level Gazebo documentation that gets published to https://gazebosim.org/docs/
https://gazebosim.org/docs
44 stars 81 forks source link

Fix "No space left on device" issue on Github Actions #390

Closed azeey closed 9 months ago

azeey commented 9 months ago

🦟 Bug fix

Summary

Our documentation deployment Action is failing with a "No space left on device" error. I think this is because we're creating docker images for each release, but not removing them even though they're not needed anymore.

This PR also removes EOL releases from the deployment script in 3d884bec62fbe259d18bb15871dcfd3f65ec4b00.

This would be easier to review by commit.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

mabelzhang commented 9 months ago

Doesn't this just remove the image right away after it's built? Or is a container being spun up elsewhere, so that the latest image won't be pruned?

azeey commented 9 months ago

Doesn't this just remove the image right away after it's built? Or is a container being spun up elsewhere, so that the latest image won't be pruned?

The documentation is generated and uploaded during the Dockerfile build process. It calls RUN scripts/build_gz.sh which calls upload_doc.sh (https://github.com/azeey/docs/blob/5a22e956259c9d93cdbe52d17ffd31c5e294bc71/tools/scripts/build_gz.sh#L33). So there's no need to keep the images around.