gazebosim / gazebo-classic

Gazebo classic. For the latest version, see https://github.com/gazebosim/gz-sim
http://classic.gazebosim.org/
Other
1.19k stars 480 forks source link

ViewController::Update is not called #1301

Open osrf-migration opened 10 years ago

osrf-migration commented 10 years ago

Original report (archived issue) by Jackie K (Bitbucket: jacquelinekay).


I am attempting to modify (resurrect?) rendering/FPSViewController. I was advised by @nkoenig to change the position of the camera in FPSViewController::Update. However, it appears that ViewController:Update never gets called. You can test this by adding a print statement to either FPSViewController::Update or OrbitViewController::Update and adding the line

#!c++

gui::get_active_camera()->SetViewController(rendering::FPSViewController::GetTypeString());

to a plugin (the constructor of a GuiPlugin such as GUIExampleTimeWidget in examples works for me).

I do not see a print statement added to FPSViewController or OrbitController. Therefore, to continue my implementation I will have to modify rendering/Camera.cc.

ViewController::Update should be fixed so that it is called when it is intended to be called, or taken out so that it does not mislead developers.

osrf-migration commented 9 years ago

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


osrf-migration commented 9 years ago

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


The coverage build claims that OrbitViewController::Update is covered:

osrf-migration commented 8 years ago

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).