Compiler warning in MoonManager.cpp

[osrf-migration]

Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

Originally posted on ogre forums:

• http://www.ogre3d.org/addonforums/viewtopic.php?f=20&t=30406

When compiling skyx with clang on Mac OS X, I get a compiler warning about MoonManager.cpp line 225: "explicitly assigning a variable of type 'Ogre::Real' (aka 'float') to itself"

http://build.osrfoundation.org/view/gazebo/job/gazebo-default-devel-homebrew-amd64-2/76/warnings7Result/package.869114785/

Here's a link to the code:

https://github.com/osrf/gazebo/blob/master/gazebo/rendering/skyx/src/MoonManager.cpp#L225

The offending line says:

center = center;

Is that a mistake? Lots of other lines in that functions say:

center = -center;

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

• Edited issue description

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

It looks like a mistake.

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

• Edited issue description

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

It was hard for me to follow the code since there isn't much documentation in the functions, so I didn't want to just change it without knowing what it should be doing.

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

Yeah, skyx is difficult. You can comment it out and leave a note.

[osrf-migration]

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).

---

• changed state from "new" to "resolved"

Commented out in pull request #1900

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

• set version to "all"

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

• changed state from "resolved" to "closed"