gazebosim / gazebo-classic

Gazebo classic. For the latest version, see https://github.com/gazebosim/gz-sim
http://classic.gazebosim.org/
Other
1.19k stars 480 forks source link

Add flags to link against test fixture #1673

Open osrf-migration opened 9 years ago

osrf-migration commented 9 years ago

Original report (archived issue) by Nate Koenig (Bitbucket: Nathan Koenig).


Should we modify gazebo's cmake config to include the test fixture? See pull request #1818.

osrf-migration commented 9 years ago

Original comment by Carlos Agüero (Bitbucket: caguero, GitHub: caguero).


Summary after some discussion with @nkoenig:

Potential solutions:

osrf-migration commented 9 years ago

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


As I said in the pull request, I'm linking specifically against gazebo_test_fixture in the benchmark repository. I think the extra work for downstream users in creating integration tests is not just linking against gazebo_test_fixture; that part is easy. There's lots of steps, though, that could be simplified:

We use some cmake macros to simplify this for ourselves. Would it be desirable to install a cmake helper macro/function intended for downstream use (similar to osrf/gazebo/cmake/GazeboTestUtils.cmake or the TestMacro.cmake in the benchmark repository)? I would ask the opinion of @dirk-thomas if we were to do so.

osrf-migration commented 9 years ago

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


We should scope the goal of this issue. Is it

  1. Make a public facing mechanism to link against the test fixture, and leave the rest of the compilation details up to the user, or
  2. Create an installable cmake helper for using gazebo's test fixture?
osrf-migration commented 8 years ago

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).