Open osrf-migration opened 9 years ago
Original comment by Carlos Agüero (Bitbucket: caguero, GitHub: caguero).
Summary after some discussion with @nkoenig:
Potential solutions:
Learn why libgazebo_server_fixture is static. This might negatively affect the time required to link an integration tests. This issue might be related. If possible, make libgazebo_server fixture a dynamic library.
Use an optional list of components when doing find_package(gazebo)
Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).
As I said in the pull request, I'm linking specifically against gazebo_test_fixture
in the benchmark repository. I think the extra work for downstream users in creating integration tests is not just linking against gazebo_test_fixture
; that part is easy. There's lots of steps, though, that could be simplified:
check_test_ran
test to catch seg-faultsWe use some cmake macros to simplify this for ourselves. Would it be desirable to install a cmake helper macro/function intended for downstream use (similar to osrf/gazebo/cmake/GazeboTestUtils.cmake or the TestMacro.cmake in the benchmark repository)? I would ask the opinion of @dirk-thomas if we were to do so.
Original comment by Nate Koenig (Bitbucket: Nathan Koenig).
We should scope the goal of this issue. Is it
Original report (archived issue) by Nate Koenig (Bitbucket: Nathan Koenig).
Should we modify gazebo's cmake config to include the test fixture? See pull request #1818.