search

gazebosim / gazebo-classic

Gazebo classic. For the latest version, see https://github.com/gazebosim/gz-sim
http://classic.gazebosim.org/
Other
1.18k stars 479 forks source link

Model editing using factory message #1954

Open osrf-migration opened 8 years ago

osrf-migration commented 8 years ago

Original report (archived issue) by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).

The factory message has an edit_name field which can be used to specify a model to be updated according to the SDF passed by the message.

The problem is that not all edits are supported and one needs to dig into the code to figure out what should work or not. We should improve the documentation of this feature, clearly defining its intended use. It's also necessary to add tests and fix the bits which are not working.

osrf-migration commented 8 years ago

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

osrf-migration commented 5 years ago

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).

Ignition msgs PR removing the field: https://bitbucket.org/ignitionrobotics/ign-msgs/pull-requests/86

azeey commented 4 years ago

Also wanted to note that SDFormat 1.7 frame semantics is not supported when updating models using edit_name in Gazebo 11.