gazebosim / gazebo-classic

Gazebo classic. For the latest version, see https://github.com/gazebosim/gz-sim
http://classic.gazebosim.org/
Other
1.19k stars 480 forks source link

(repost of #1970) Events::step and Events::stop never called #1971

Open osrf-migration opened 8 years ago

osrf-migration commented 8 years ago

Original report (archived issue) by udi B (Bitbucket: UdiB).


(Reposting #1970 which was mistakenly posted anonymously)

Reading source at tag gazebo7_7.1.0

gazebo / common / Events.hh 298-304 defines events for simulation "stop", "step" and "pause".

gazebo / physics / World.cc 155 even connects a handler to the "step" event.

However in the entire source tree I couldn't find a single call to event::Events::step(), meaning that the event is probably never triggered.

In fact, the step handler routine in World.cc is being called directly from World::OnControl() (line 1295), bypassing the event mechanism entirely.

The same applies to the "stop" event except that it's neither hooked nor triggered by any code.

I suppose that events were put there in the first place to allow plugins to hook them, but this is rather pointless when they're never triggered.

osrf-migration commented 8 years ago

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


Issue #1970 was marked as a duplicate of this issue.

osrf-migration commented 8 years ago

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


Changing from major to minor bug.

osrf-migration commented 8 years ago

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).