Visual rotation marker should indicate the axis of rotation when using hotkeys

gazebosim / gazebo-classic

Gazebo classic. For the latest version, see https://github.com/gazebosim/gz-sim

http://classic.gazebosim.org/

Other

1.2k stars 482 forks source link

Visual rotation marker should indicate the axis of rotation when using hotkeys #2155

Open osrf-migration opened 7 years ago

osrf-migration commented 7 years ago

Original report (archived issue) by Shane Loretz (Bitbucket: Shane Loretz, GitHub: sloretz).

When the user has selected a rotation tool and presses one of the hotkeys, the marker should change to reflect that hotkey rotation happens in the global frame.

Currently rotating twice with hotkeys causes second rotation to be different from the rotation indicated by the visual marker:

Drag a box into the world
Press r to use the rotate tool
Hold x then left-click drag the model until the Blue ring (z axis rotation) is vertical
Hold z then left-click drag the model

When a hotkey is pressed the marker could change to a single ring around the model oriented with the global axis the hotkey pertains to. If the 'z' key is pressed, the current marker would disappear, and a blue ring would appear around the model aligned with the global Z axis.

osrf-migration commented 7 years ago

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

changed state from "new" to "closed"

This is the correct behavior. The x,y,z hot keys always refer to the global coordinate frame.

osrf-migration commented 7 years ago

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).

In that case, I think this is at the minimum confusing. For example, when you press Shift to switch to the global frame, the interactive markers rotate to reflect the axes which you're going to be rotating about. In the situation described here, the markers show one thing, and do another one.

osrf-migration commented 7 years ago

Original comment by Shane Loretz (Bitbucket: Shane Loretz, GitHub: sloretz).

I think the axis of the rotation with hotkeys might be a surprise to a user because it differs from the rotation marker. What do you think about the marker changing when a hotkey is pressed?

For example: when the user has the rotation tool selected and holds the 'z' key, the existing markers disappear and a blue ring around the global z axis appears around the model. When the 'z' key is released the previous rotation markers return

osrf-migration commented 7 years ago

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

Changing the visual sounds fine. Can you change the title and description of this issue, or create a new feature request? Also, target this to 8.1 please.

osrf-migration commented 7 years ago

Original comment by Shane Loretz (Bitbucket: Shane Loretz, GitHub: sloretz).

Edited issue description* changed kind from "bug" to "enhancement"
changed version from "8.0" to "8.1"
changed title from "Rotating twice with hotkeys causes second rotation to be about wrong axis" to "Visual rotation marker should indicate the axis of rotation when using hotkeys"

Change bug to feature request

osrf-migration commented 7 years ago

Original comment by Shane Loretz (Bitbucket: Shane Loretz, GitHub: sloretz).

changed state from "closed" to "open"

Reopen as feature request