search

gazebosim / gazebo-classic

Gazebo classic. For the latest version, see https://github.com/gazebosim/gz-sim
http://classic.gazebosim.org/
Other
1.17k stars 477 forks source link

User camera follow track_visual not working Gazebo 7.5.0 #2219

Open osrf-migration opened 7 years ago

osrf-migration commented 7 years ago

Original report (archived issue) by marclecerf (Bitbucket: marclecerf).

The "follow" user camera mode does not properly track model orientation changes in Gazebo 7.5.0. (it does follow the model position change, however.)

I recently upgraded from Gazebo 6, where this feature was behaving quite nicely.

I can work to provide detailed test steps and docs if needed, but after a code inspection it's likely because the new track_visual SDF element processing is not present in the code base despite appearing to have been merged on a "gazebo_7_1" branch.

I'm still quite new to the Gazebo development cycle so I don't know exactly what branch is the main Gazebo 7 patch support, but I'm assuming it's "gazebo7"?

gazebo7 branch, ref TrackVisualFromSDF method line 766

https://github.com/osrf/gazebo/blob/7ea3368bb8734dd9c6dfe6c9c37b3ca9427d1148/gazebo/msgs/msgs.cc

compare this to the gazebo8 and default branches and you'll see most of the track_visual elements from the SDF spec v1.5+ are not being processed.

I noticed the new track_visual behavior PR

https://osrf-migration.github.io/gazebo-gh-pages/#!/osrf/gazebo/pull-requests/1980/static-camera-when-following-a-model/diff

that was merged to "gazebo_7_1" but this branch does not exist anymore, I'm getting a 404 when I try to view it.

This is an important issue for users working particularly with airborne models that change orientation frequently.

osrf-migration commented 7 years ago

Original comment by marclecerf (Bitbucket: marclecerf).

osrf-migration commented 7 years ago

Original comment by marclecerf (Bitbucket: marclecerf).

osrf-migration commented 7 years ago

Original comment by marclecerf (Bitbucket: marclecerf).

@nkoenig and @ocrave I see you were involved in the camera follow functionality updates, perhaps you guys might be able to shed light on this issue? Thanks!

osrf-migration commented 7 years ago

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).

osrf-migration commented 7 years ago

Original comment by Olivier Crave (Bitbucket: ocrave).

As far I can see, the pull request was originally merged in a temporary branch named gazebo_7_1 on purpose, but if you take a look in the changelog, you will see that the feature was only introduced in gazebo 8, so I think it is normal that it does not appear in 7.5.