Closed adityapande-1995 closed 2 years ago
I'd like to see a unit test for the new
HeightmapData::LoadTerrainFile
overload in HeightmapData_TEST.ccI made several other comments as well that I have implemented in 9cdeebc that you may consider cherry-picking
Added test https://github.com/osrf/gazebo/pull/3258/commits/8dc627054d2297c34de55794fc63438875c188e5
This PR is an ongoing set of PRs to make lunar dem support available in gazebo classic.
Problem tackled
For gzserver
HeightmapDataLoader::LoadDEMAsTerrain()
needs access to the world's spherical coordiantes object to load lunar DEMs correctly. This in turn is called byHeightmapDataLoader::LoadTerrain()
, which is loaded byHeightmapShape::LoadTerrainFile()
which ultimately has access to the spherical coordiantes object.This PR overloads the above functions so that the spherical coordinates pointer is available to the DEM object.
For gzclient
Possible issues
This might still lead to some ABI incompatibility issues, and I can go for a different approach then, probably by renaming functions or deprecating old ones.
It is also possible to direct use the service in
HeightmapDataLoader::LoadDEMAsTerrain()
, but that might slow down the loading of DEMs even in server mode.