gazebosim / gazebo-classic

Gazebo classic. For the latest version, see https://github.com/gazebosim/gz-sim

http://classic.gazebosim.org/

Other

1.2k stars 481 forks source link

Fix build with boost 1.85.0 #3386

Closed scpeters closed 6 months ago

scpeters commented 6 months ago

🦟 Bug fix

Fixes #3385.

Summary

The branch_path API was deprecated and has been removed in boost 1.85.0. This uses the recommended replacement method parent_path.

Checklist

[X] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

scpeters commented 6 months ago

this isn't quite enough; it's still failing

scpeters commented 6 months ago

looks like basename and extension were deprecated / removed as well

/Users/scpeters/ws/gazebo/src/gazebo/gazebo/util/LogPlay.cc:417:29: error: no member named 'basename' in namespace 'boost::filesystem'
  return boost::filesystem::basename(this->dataPtr->filename) +
         ~~~~~~~~~~~~~~~~~~~^
/Users/scpeters/ws/gazebo/src/gazebo/gazebo/util/LogPlay.cc:418:24: error: no member named 'extension' in namespace 'boost::filesystem'
    boost::filesystem::extension(this->dataPtr->filename);
    ~~~~~~~~~~~~~~~~~~~^
2 errors generated.

https://github.com/boostorg/filesystem/blob/boost-1.84.0/include/boost/filesystem/convenience.hpp#L28-L38

scpeters commented 6 months ago

looks like basename and extension were deprecated / removed as well

/Users/scpeters/ws/gazebo/src/gazebo/gazebo/util/LogPlay.cc:417:29: error: no member named 'basename' in namespace 'boost::filesystem'
  return boost::filesystem::basename(this->dataPtr->filename) +
         ~~~~~~~~~~~~~~~~~~~^
/Users/scpeters/ws/gazebo/src/gazebo/gazebo/util/LogPlay.cc:418:24: error: no member named 'extension' in namespace 'boost::filesystem'
    boost::filesystem::extension(this->dataPtr->filename);
    ~~~~~~~~~~~~~~~~~~~^
2 errors generated.

https://github.com/boostorg/filesystem/blob/boost-1.84.0/include/boost/filesystem/convenience.hpp#L28-L38

fix in https://github.com/gazebosim/gazebo-classic/pull/3386/commits/27c2277a2376f9d82755e975ae8b564d9d6ca6ed