gazebosim / gazebo-classic

Gazebo classic. For the latest version, see https://github.com/gazebosim/gz-sim
http://classic.gazebosim.org/
Other
1.19k stars 480 forks source link

Gazebo's find_package rules do no expose plugins #776

Open osrf-migration opened 11 years ago

osrf-migration commented 11 years ago

Original report (archived issue) by Tully Foote (Bitbucket: Tully Foote, GitHub: tfoote).


gazebo should expose the optional components like other libraries with the COMPONENTS keyword, in particular the plugin libraries.

So it would be like: find_package(gazebo REQUIRED COMPONENTS Core CameraPlugin)

This would allow the find_package to correctly populate the GAZEBO_LIBRARIES variable to include the plugins instead of requiring the downstream user to call

set_target_properties(TARGET_NAME PROPERTIES LINK_FLAGS "${ld_flags}")

for every target. And then you have to hard code the plugin library name in the TARGET_LINK_LIBRARIES call.

The default if you don't pass any components is that you get all components. This is patterend off of Boost and several other libraries.

osrf-migration commented 8 years ago

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


osrf-migration commented 7 years ago

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).