The previous implementation of FindGzAssimp had issues on Windows, specifically on Windows it seems that it is necessary to use find_package instead of pkg-config, i.e. vcpkg prints the following:
but using find_package sets global variables that break downstream users that reimplement their own version of FindAssimp such as dartsim.
For these reasons the implementation now uses find_package but clears the cache from the assimp variables and only uses the GzAssimp namespaced variables. Downstream behavior is now unchanged.
Tested with the gz-common PR to make sure CI is :heavy_check_mark:
Checklist
[x] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.
🦟 Bug fix
Summary
The previous implementation of FindGzAssimp had issues on Windows, specifically on Windows it seems that it is necessary to use
find_package
instead ofpkg-config
, i.e. vcpkg prints the following:but using
find_package
sets global variables that break downstream users that reimplement their own version ofFindAssimp
such as dartsim.For these reasons the implementation now uses find_package but clears the cache from the
assimp
variables and only uses theGzAssimp
namespaced variables. Downstream behavior is now unchanged.Tested with the gz-common PR to make sure CI is :heavy_check_mark:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.