gazebosim / gz-cmake

A set of CMake modules that are used by the C++-based Gazebo projects.

https://gazebosim.org/libs/cmake

Apache License 2.0

27 stars 31 forks source link

2 to 3 20220830 #309

Closed nkoenig closed 2 years ago

nkoenig commented 2 years ago

➡️ Forward port\

@methylDragon, can you check this to make sure I did this right?

Port ign-cmake2 to gz-cmake3

Branch comparison: https://github.com/gazebosim/gz-cmake/compare/gz-cmake3...ign-cmake2

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

scpeters commented 2 years ago

no, I thought we intentionally didn't add the gz/utilities/* header files on this branch? cc @chapulina

scpeters commented 2 years ago

no, I thought we intentionally didn't add the gz/utilities/* header files on this branch? cc @chapulina

but then we backported them in #303, hmm...

chapulina commented 2 years ago

Yeah we had skipped them on purpose since they're deprecated. If it makes it easier to have the gz counterpart so that everything is consistent across all libraries, I think that's ok though

scpeters commented 2 years ago

Yeah we had skipped them on purpose since they're deprecated. If it makes it easier to have the gz counterpart so that everything is consistent across all libraries, I think that's ok though

ok, that was my mistake for not catching that in #303, which we've already released. This is fine