gazebosim / gz-cmake

A set of CMake modules that are used by the C++-based Gazebo projects.
https://gazebosim.org/libs/cmake
Apache License 2.0
27 stars 31 forks source link

Deprecate SuppressWarning.hh with #warning #367

Closed scpeters closed 1 year ago

scpeters commented 1 year ago

🎉 New feature

Closes #348

Summary

The gz/utilities/SuppressWarning.hh header file is redundant with gz/utils/SuppressWarning.hh, so deprecate it.

Test it

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

mjcarroll commented 1 year ago

@scpeters I think this is good to un-draft?

scpeters commented 1 year ago

@scpeters I think this is good to un-draft?

I was hoping to test it before un-drafting it, and I haven't done that yet. I'll try updating one of the examples

scpeters commented 1 year ago

I tested it, and the #pragma wasn't generating a warning, so I switched to #warning, which will either print a compiler warning or fail with a compiler error. Either way it will get attention