gazebosim / gz-cmake

A set of CMake modules that are used by the C++-based Gazebo projects.
https://gazebosim.org/libs/cmake
Apache License 2.0
27 stars 31 forks source link

Remove example_INSTALL_DIR from PREFIX_PATH on examples #421

Closed j-rivero closed 7 months ago

j-rivero commented 7 months ago

🦟 Bug fix

Summary

Remove the example_INSTALL_DIR to be passed to CMAKE_PREFIX_PATH since it is probably unused since the separator is wrong (semicolon instead of a colon). This triggered my attention since Noble has a warning with 3.28 CMake version.

CMake Warning:
  Ignoring extra path from command line:

   "/home/jenkins/workspace/gz_cmake-ci-gz-cmake3-noble-amd64/build/install/RelWithDebInfo"

CMake Warning:
  Ignoring extra path from command line:

   "/home/jenkins/workspace/gz_cmake-ci-gz-cmake3-noble-amd64/build/install/RelWithDebInfo"

CMake Warning:
  Ignoring extra path from command line:

   "/home/jenkins/workspace/gz_cmake-ci-gz-cmake3-noble-amd64/build/install/Release"

CMake Warning:
  Ignoring extra path from command line:

   "/home/jenkins/workspace/gz_cmake-ci-gz-cmake3-noble-amd64/build/install/Release"

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.