gazebosim / gz-cmake

A set of CMake modules that are used by the C++-based Gazebo projects.
https://gazebosim.org/libs/cmake
Apache License 2.0
27 stars 31 forks source link

Fix lcov on Ubuntu Noble #436

Closed azeey closed 4 months ago

azeey commented 4 months ago

🦟 Bug fix

Summary

The coverage build in https://github.com/gazebosim/gz-fuel-tools/pull/427 is failing due to some issues in lcov. From my testing and following the approach in https://github.com/ros2/ci/pull/771, this PR seems to fix the problem.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

scpeters commented 4 months ago

tested with https://github.com/gazebosim/gz-fuel-tools/pull/427 in https://github.com/gazebosim/gz-fuel-tools/pull/428. the workflow passes, though there still seems like an issue with the codecov upload

scpeters commented 4 months ago

uh oh, this breaks Ionic packages still using Jammy for coverage testing (see https://github.com/gazebosim/gz-utils/pull/133)