With this patch, running cmake -DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON -P cmake_install.cmake from the build directory of any of our libraries will succeed showing that no absolute install destination is used.
Checklist
[ ] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.
🦟 Bug fix
Summary
This makes it so that all of our libraries use relative install paths and work well in build systems that don't set
CMAKE_INSTALL_PREFIX.gz_cmake_vendoris patched with this so it can build on the ROS buildfarm (see https://github.com/gazebo-release/gz_cmake_vendor/pull/4).With this patch, running
cmake -DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON -P cmake_install.cmakefrom thebuilddirectory of any of our libraries will succeed showing that no absolute install destination is used.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.