Open azeey opened 2 months ago
I noticed this too. I think the fix needs to be in the following lines of gz-config.cmake.in:
gz_pkg_config_entry
is called once with the package name, but we should collect the names of required components and include those as well in a space-separated string (like gz-utils3 gz-utils3-log
). This could be done by:
gz_pkg_config_append_entry
macro and calling that within the component for loopgz_pkg_config_entry
after the for looppotential fix in https://github.com/gazebosim/gz-cmake/pull/451
Per our discussion in the PMC meeting, we should remove pkg-config support from gz-cmake since it's not used anywhere in our code base and most users are probably not using it.
Environment
Description
Steps to reproduce
Right before
gz_configure_build
in https://github.com/gazebosim/gz-cmake/blob/3b33067c07460f95af3cbebfff76bdcff4e2d5fe/examples/core_nodep/CMakeLists.txt#L7gz-utils3-log
installed, build project and read the contents ofcmake/pkgconfig/gz-core_no_deps.pc
in thebuild
directory. You should seeName: Gazebo core_no_deps Description: A set of core_no_deps classes for robot applications Version: 0.1.0 Requires: gz-cmake4 >= 1.1 gz-utils3 Requires.private: Libs: -L${libdir} -lgz-core_no_deps Libs.private: CFlags: -I${includedir} -std=c++11