Make the dependency on FreeImage optional

gazebosim / gz-common

An audio-visual library supports processing audio and video files, a graphics library can load a variety 3D mesh file formats into a generic in-memory representation, and the core library of Gazebo Common contains functionality that spans Base64 encoding/decoding to thread pools.

https://gazebosim.org

Apache License 2.0

12 stars 38 forks source link

Make the dependency on FreeImage optional #388

Open mahiuchun opened 2 years ago

mahiuchun commented 2 years ago

Desired behavior

gz-common could be built without using FreeImage.

Alternatives considered

N/A

Implementation suggestion

Use https://github.com/nothings/stb/blob/master/stb_image.h for image loading.

Additional context

By not supporting less commonly used image formats, the attack surface of image loading is reduced.
FreeImage has an active SVN but they have not made a release since 2018.

wentasah commented 2 months ago

This might be a good idea, as freeimage is known to contain many security vulnerabilities.

mjcarroll commented 2 months ago

Yes, there has been a little bit of work attempting to replace the dependency with something like stb (https://github.com/gazebosim/gz-common/pull/590) but I haven't had bandwidth to continue on it.