gazebosim / gz-common

An audio-visual library supports processing audio and video files, a graphics library can load a variety 3D mesh file formats into a generic in-memory representation, and the core library of Gazebo Common contains functionality that spans Base64 encoding/decoding to thread pools.

https://gazebosim.org

Apache License 2.0

15 stars 39 forks source link

Merge ign-common4 ➡️ gz-common5 #572

Closed azeey closed 10 months ago

azeey commented 10 months ago

➡️ Forward port

Port ign-common4 ➡️ gz-common5

Branch comparison: https://github.com/gazebosim/gz-common/compare/gz-common5...ign-common4

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

azeey commented 10 months ago

@mjcarroll I couldn't properly port https://github.com/gazebosim/gz-common/pull/561 since a lot has changed. Is it needed for gz-common5?

mjcarroll commented 10 months ago

No, it's no longer necessary as we changed how the filesystem functions warn when switching to std::filesystem.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c948a9d) 83.65% compared to head (2d06bf7) 83.65%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## gz-common5 #572 +/- ## =========================================== Coverage 83.65% 83.65% =========================================== Files 90 90 Lines 10273 10273 =========================================== Hits 8594 8594 Misses 1679 1679 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.