gazebosim / gz-common

An audio-visual library supports processing audio and video files, a graphics library can load a variety 3D mesh file formats into a generic in-memory representation, and the core library of Gazebo Common contains functionality that spans Base64 encoding/decoding to thread pools.
https://gazebosim.org
Apache License 2.0
15 stars 39 forks source link

Clarify GDAL version requirement #574

Closed cottsay closed 9 months ago

cottsay commented 10 months ago

🦟 Bug fix

Summary

The default behavior of pkg-config seems to be an exact version match.

This was discovered when the RPM build process automatically added package dependencies based on the *.pc files generated by the project, one of which contained gdal = 3.0. This bug can be confirmed on any distro that has a gdal version other than 3.0, such as Ubuntu Jammy:

$ pkg-config --cflags gz-common5-geospatial
Package 'gz-common5-geospatial' requires 'gdal = 3.0' but version of gdal is 3.4.1
$ echo $?
1

It's interesting that the version comparison behaves differently in the first dependency level (which did not produce an error) than it does in subsequent levels. Perhaps there is a bug in gz-cmake as well.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0b8428a) 83.65% compared to head (f6372e4) 83.65%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## gz-common5 #574 +/- ## =========================================== Coverage 83.65% 83.65% =========================================== Files 90 90 Lines 10273 10273 =========================================== Hits 8594 8594 Misses 1679 1679 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.