search

gazebosim / gz-common

An audio-visual library supports processing audio and video files, a graphics library can load a variety 3D mesh file formats into a generic in-memory representation, and the core library of Gazebo Common contains functionality that spans Base64 encoding/decoding to thread pools.
https://gazebosim.org
Apache License 2.0
16 stars 40 forks source link

Generate a more unique texture name for glb embedded textures #606

Closed iche033 closed 6 months ago

iche033 commented 6 months ago

🦟 Bug fix

Summary

For glb meshes, our assimp loader generates a unique texture name for each embedded texture by prepending the 'scene' or 'root node' name of the glb mesh. However, the generated name may not always be unique. It's possible that different glb files have the same scene and root name. This PR adds the file base name of the mesh to the generated texture name string to make it more unique.

I think this change is similar to the intention in https://github.com/gazebosim/gz-common/pull/565 where it's also trying to make texture names unique.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.51%. Comparing base (2d06bf7) to head (6c43c95). Report is 23 commits behind head on gz-common5.

:exclamation: Current head 6c43c95 differs from pull request most recent head 4b07788. Consider uploading reports for the commit 4b07788 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## gz-common5 #606 +/- ## ============================================== - Coverage 83.65% 80.51% -3.15% ============================================== Files 90 93 +3 Lines 10273 13594 +3321 ============================================== + Hits 8594 10945 +2351 - Misses 1679 2649 +970 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.