gazebosim / gz-common

An audio-visual library supports processing audio and video files, a graphics library can load a variety 3D mesh file formats into a generic in-memory representation, and the core library of Gazebo Common contains functionality that spans Base64 encoding/decoding to thread pools.
https://gazebosim.org
Apache License 2.0
16 stars 40 forks source link

Fix AssimpLoader collada texture coordinates #634

Closed iche033 closed 2 months ago

iche033 commented 2 months ago

🦟 Bug fix

Fixes #633

Summary

Fixes UNIT_AssimpLoader_TEST with assimp 5.4.3. This should fix homebrew CI.

This PR tweaks the way we check for texture coordinates from assimp. Empty texture coordinate slots are now allowed as of https://github.com/assimp/assimp/pull/5636. The new logic should be compatible with assimp 5.4.3 and prior versions

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

iche033 commented 2 months ago

Homebrew CI is fixed. This PR is ready for review.