gazebosim / gz-common

An audio-visual library supports processing audio and video files, a graphics library can load a variety 3D mesh file formats into a generic in-memory representation, and the core library of Gazebo Common contains functionality that spans Base64 encoding/decoding to thread pools.
https://gazebosim.org
Apache License 2.0
16 stars 40 forks source link

Fix severity level of gzlog #635

Closed azeey closed 2 months ago

azeey commented 2 months ago

🦟 Bug fix

Fixes #632

Summary

The severity level of gzlog was incorrectly set to err. Changing this to trace solves two problems:

  1. The log message is now a lot less alarming
  2. When running gz sim -v4, this message is not shown on the console. It will only be logged to file. It does show up on the console if you run with -v5.

The second point is technically a behavior change since in Harmonic, regardless of the verbosity level, gzlog would never show up on the console. However, duplicating that behavior with the new Console implementation proved to be very complicated. So, I propose we change the meaning of gzlog to be equivalent to gztrace.


Note We'll have to make new prereleases of all downstream libraries for this fix to propagate. I vote we just wait for the stable release.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

iche033 commented 2 months ago

The test failures look related, probably due to behavior change?