gazebosim / gz-gui

Builds on top of Qt to provide widgets which are useful when developing robotics applications, such as a 3D view, plots, dashboard, etc, and can be used together in a convenient unified interface.
https://gazebosim.org
Apache License 2.0
75 stars 43 forks source link

Update cmd/CMakeLists to conform with all other gz libraries (#478) #480

Closed azeey closed 2 years ago

azeey commented 2 years ago

➡️ Forward port

Cherry-pick #478 from ign-gui3 since merging forward would introduce new features during feature freeze. This is needed to make gz gui work properly. It could come in a minor release since gz gui is not a commonly used tool.

Note to maintainers: Remember to use Rebase-and-merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

jennuine commented 2 years ago

These tests are failing:

CmdLine.list
gzTest.GuiHelpVsCompletionFlags
codecov[bot] commented 2 years ago

Codecov Report

Merging #480 (131eeb4) into gz-gui7 (b5f354a) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           gz-gui7     #480   +/-   ##
========================================
  Coverage    67.82%   67.82%           
========================================
  Files           44       44           
  Lines         4826     4826           
========================================
  Hits          3273     3273           
  Misses        1553     1553           
Impacted Files Coverage Δ
src/plugins/camera_tracking/CameraTracking.cc 68.45% <ø> (ø)
src/plugins/grid_config/GridConfig.cc 22.35% <ø> (ø)
src/plugins/grid_config/GridConfig.hh 100.00% <ø> (ø)
src/plugins/image_display/ImageDisplay.cc 31.70% <ø> (ø)
...interactive_view_control/InteractiveViewControl.cc 17.88% <ø> (ø)
src/plugins/key_publisher/KeyPublisher.cc 56.52% <ø> (ø)
src/plugins/marker_manager/MarkerManager.cc 59.41% <ø> (ø)
src/plugins/minimal_scene/MinimalScene.cc 65.61% <ø> (ø)
src/plugins/publisher/Publisher.cc 90.78% <ø> (ø)
src/plugins/screenshot/Screenshot.cc 30.12% <ø> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.