gazebosim / gz-gui

Builds on top of Qt to provide widgets which are useful when developing robotics applications, such as a 3D view, plots, dashboard, etc, and can be used together in a convenient unified interface.
https://gazebosim.org
Apache License 2.0
67 stars 39 forks source link

Remove unused headers #490

Closed jennuine closed 1 year ago

jennuine commented 1 year ago

🦟 Bug fix

Summary

Remove unused headers, which were causing the abi checker to fail (first detected in https://github.com/gazebosim/gz-gui/pull/486)

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

methylDragon commented 1 year ago

This PR needs https://github.com/gazebosim/gz-gui/pull/486 to pass I say we just force a merge :grimacing:, since we'll need a forced merge anyway to get the ABI checker to be happy.

Help! @scpeters ?

scpeters commented 1 year ago

@osrf-jenkins run tests please

jennuine commented 1 year ago

@scpeters https://github.com/gazebosim/gz-gui/pull/486 fixes INTEGRATION_ExamplesBuild_TEST but the abi checker is failing. This PR should fix abi but (from my understanding) not until after it's merged. I do not have privileges to override the merge