search

gazebosim / gz-gui

Builds on top of Qt to provide widgets which are useful when developing robotics applications, such as a 3D view, plots, dashboard, etc, and can be used together in a convenient unified interface.
https://gazebosim.org
Apache License 2.0
75 stars 43 forks source link

Fixes warnings about onFoo connections in Qt QML #493

Closed mjcarroll closed 1 year ago

mjcarroll commented 2 years ago

🦟 Bug fix

Partially fixes https://github.com/gazebosim/gz-gui/issues/481 Split from #404

Summary

Cleans up warnings from Qt in the style of:

QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

mjcarroll commented 2 years ago

I believe I introduced one of these test failures, do not merge.

azeey commented 1 year ago

Should we close this for now and reopen when we're on a version of gz-gui that doesn't support Focal?

mjcarroll commented 1 year ago

Sounds good to me.

jennuine commented 1 year ago

Fixed in https://github.com/gazebosim/gz-gui/pull/534