Closed bperseghetti closed 4 months ago
@osrf-jenkins run tests please!
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
8dae037
) 72.98% compared to head (290c060
) 69.18%. Report is 8 commits behind head on gz-gui7.:exclamation: Current head 290c060 differs from pull request most recent head bea60bd. Consider uploading reports for the commit bea60bd to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@bperseghetti I haven't seen any movement on this one and it targets garden branches, so I'm going to remove the beta label for now.
@bperseghetti , friendly ping. Could you review the feedback and we'll try to merge this patch?
@bperseghetti , friendly ping. Could you review the feedback and we'll try to merge this patch?
Yeah, will look it over again here this weekend and see if I can't make the requested changes.
@bperseghetti there are CI errors:
/home/jenkins/workspace/gz_gui-ci-pr_any-focal-amd64/gz-gui/test/integration/follow_config.cc:162
Expected: (sleep) < (maxSleep), actual: 61 vs 60
@bperseghetti there are CI errors:
/home/jenkins/workspace/gz_gui-ci-pr_any-focal-amd64/gz-gui/test/integration/follow_config.cc:162 Expected: (sleep) < (maxSleep), actual: 61 vs 60
I actually was planning to close this and open a new PR that has a more "holistic" approach to controlling the follow camera including what was done in here but more.
I just need to rebase that work on humble as I no longer plan to target it to garden (due to relatively sooner EOL).
Closing in favor of PR #619
🦟 Bug fix
Fixes #514
Summary
Now you can set the pgain of the follow camera when following objects. This is needed for extremely high speed objects.
https://user-images.githubusercontent.com/10233412/215242320-eaa9d430-e853-49c6-a0de-81a69dc6c258.mp4
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.