search

gazebosim / gz-gui

Builds on top of Qt to provide widgets which are useful when developing robotics applications, such as a 3D view, plots, dashboard, etc, and can be used together in a convenient unified interface.
https://gazebosim.org
Apache License 2.0
67 stars 39 forks source link

Forward port 3 to 6 #518

Closed nkoenig closed 1 year ago

nkoenig commented 1 year ago

➡️ Forward port

Port ign-gui3 to ign-gui6

Branch comparison: https://github.com/gazebosim/gz-gui/compare/ign-gui6...ign-gui3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

codecov[bot] commented 1 year ago

Codecov Report

Merging #518 (ad91f70) into ign-gui6 (650d505) will not change coverage. The diff coverage is 83.67%.

:exclamation: Current head ad91f70 differs from pull request most recent head 8579d00. Consider uploading reports for the commit 8579d00 to get more accurate results

@@            Coverage Diff            @@
##           ign-gui6     #518   +/-   ##
=========================================
  Coverage     69.79%   69.79%           
=========================================
  Files            40       40           
  Lines          5324     5324           
=========================================
  Hits           3716     3716           
  Misses         1608     1608
Impacted Files Coverage Δ
src/Dialog.cc 100.00% <ø> (ø)
src/DragDropModel.cc 100.00% <ø> (ø)
src/GuiEvents.cc 100.00% <ø> (ø)
src/MainWindow.cc 95.83% <ø> (ø)
src/PlottingInterface.cc 56.52% <ø> (ø)
src/Plugin.cc 82.68% <ø> (ø)
src/SearchModel.cc 96.55% <ø> (ø)
src/plugins/grid_config/GridConfig.cc 22.35% <ø> (ø)
src/plugins/image_display/ImageDisplay.cc 96.36% <ø> (ø)
src/plugins/image_display/ImageDisplay.hh 100.00% <ø> (ø)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jennuine commented 1 year ago

For some reason homebrew CI is having issues finding ignition-math6 :thinking: 

CMake Warning at /usr/local/share/cmake/ignition-cmake2/cmake2/IgnUtils.cmake:197 (find_package):
  By not providing "Findignition-math6.cmake" in CMAKE_MODULE_PATH this
  project has asked CMake to find a package configuration file provided by
  "ignition-math6", but CMake did not find one.

  Could not find a package configuration file provided by "ignition-math6"
  (requested version 6.5) with any of the following names:

    ignition-math6Config.cmake
    ignition-math6-config.cmake

  Add the installation prefix of "ignition-math6" to CMAKE_PREFIX_PATH or set
  "ignition-math6_DIR" to a directory containing one of the above files.  If
  "ignition-math6" provides a separate development package or SDK, be sure it
  has been installed.
iche033 commented 1 year ago

For some reason homebrew CI is having issues finding ignition-math6

probably related: https://github.com/osrf/homebrew-simulation/pull/2206

jennuine commented 1 year ago

@osrf-jenkins run tests please

mjcarroll commented 1 year ago

@osrf-jenkins retest this please

j-rivero commented 1 year ago

Looking into the test failures for Github actions:

Problems on Jammy are verbose. There are some warnings about deprecated use of the API:

2023-02-14T19:38:44.7392771Z 53/58 Test #53: INTEGRATION_minimal_scene ...................***Exception: SegFault  0.97 sec
2023-02-14T19:38:44.7393165Z Running main() from /github/workspace/test/gtest/src/gtest_main.cc
2023-02-14T19:38:44.7393466Z [==========] Running 2 tests from 1 test case.
2023-02-14T19:38:44.7393929Z [----------] Global test environment set-up.
2023-02-14T19:38:44.7394272Z [----------] 2 tests from MinimalSceneTest
2023-02-14T19:38:44.7394530Z [ RUN      ] MinimalSceneTest.Load
2023-02-14T19:38:44.7394915Z QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-root'
2023-02-14T19:38:44.7395677Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:/qml/StyleDialog.qml:112:3: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
2023-02-14T19:38:44.7396576Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:/qml/StyleDialog.qml:105:3: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
2023-02-14T19:38:44.7397617Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:/qml/StyleDialog.qml:98:3: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
2023-02-14T19:38:44.7399789Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:102:3: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
2023-02-14T19:38:44.7400816Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:/qml/PluginMenu.qml:27:3: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
2023-02-14T19:38:44.7401640Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:52: TypeError: Cannot read property 'dialogOnExitText' of null
2023-02-14T19:38:44.7402270Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:54: TypeError: Cannot read property 'exitDialogShowCloseGui' of null
2023-02-14T19:38:44.7403007Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:53: TypeError: Cannot read property 'exitDialogShowShutdown' of null
2023-02-14T19:38:44.7403594Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:251: TypeError: Cannot read property 'showDrawer' of null
2023-02-14T19:38:44.7404202Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:/qml/SideDrawer.qml:93: TypeError: Cannot read property 'showDefaultDrawerOpts' of null
2023-02-14T19:38:44.7404817Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:/qml/IgnSplit.qml:56: TypeError: Cannot read property 'pluginCount' of null
2023-02-14T19:38:44.7405413Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:41: TypeError: Cannot read property 'toolBarColorLight' of null
2023-02-14T19:38:44.7406013Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:42: TypeError: Cannot read property 'toolBarTextColorLight' of null
2023-02-14T19:38:44.7406600Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:43: TypeError: Cannot read property 'toolBarColorDark' of null
2023-02-14T19:38:44.7407196Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:44: TypeError: Cannot read property 'toolBarTextColorDark' of null
2023-02-14T19:38:44.7407815Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:45: TypeError: Cannot read property 'pluginToolBarColorLight' of null
2023-02-14T19:38:44.7408450Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:46: TypeError: Cannot read property 'pluginToolBarTextColorLight' of null
2023-02-14T19:38:44.7409060Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:47: TypeError: Cannot read property 'pluginToolBarColorDark' of null
2023-02-14T19:38:44.7409725Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:48: TypeError: Cannot read property 'pluginToolBarTextColorDark' of null
2023-02-14T19:38:44.7410323Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:50: TypeError: Cannot read property 'defaultExitAction' of null
2023-02-14T19:38:44.7410910Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:51: TypeError: Cannot read property 'showDialogOnExit' of null
2023-02-14T19:38:44.7411501Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:55: TypeError: Cannot read property 'exitDialogShutdownText' of null
2023-02-14T19:38:44.7412169Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:56: TypeError: Cannot read property 'exitDialogCloseGuiText' of null
2023-02-14T19:38:44.7412756Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:66: TypeError: Cannot read property 'toolBarColorLight' of null
2023-02-14T19:38:44.7413345Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:76: TypeError: Cannot read property 'toolBarTextColorLight' of null
2023-02-14T19:38:44.7413951Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:/qml/PluginMenu.qml:126: TypeError: Cannot call method 'PluginListModel' of null
2023-02-14T19:38:44.7414531Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:219: TypeError: Cannot read property 'showPluginMenu' of null
2023-02-14T19:38:44.7415098Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:202: TypeError: Cannot read property 'showDrawer' of null
2023-02-14T19:38:44.7415652Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:188: TypeError: Cannot read property 'showDrawer' of null
2023-02-14T19:38:44.7416402Z [GUI] [Wrn] [Application.cc:797] [QT] file::qml/IgnCard.qml:128: TypeError: Cannot read property 'pluginToolBarColorLight' of null
2023-02-14T19:38:44.7417140Z [GUI] [Wrn] [Application.cc:797] [QT] file::qml/IgnCard.qml:139: TypeError: Cannot read property 'pluginToolBarTextColorLight' of null
2023-02-14T19:38:44.7417658Z [Dbg] [Application.cc:92] Initializing application.
2023-02-14T19:38:44.7418074Z [GUI] [Dbg] [Application.cc:555] Create main window
2023-02-14T19:38:44.7418538Z [GUI] [Dbg] [Application.cc:426] Loading plugin [MinimalScene]
2023-02-14T19:38:44.7419010Z [GUI] [Msg] Added plugin [3D Scene] to main window
2023-02-14T19:38:44.7419596Z [GUI] [Msg] Loaded plugin [MinimalScene] from path [/github/workspace/build/lib/libMinimalScene.so]
2023-02-14T19:38:44.7420111Z [GUI] [Dbg] [Application.cc:140] Terminating application.
2023-02-14T19:38:44.7420424Z [       OK ] MinimalSceneTest.Load (179 ms)
2023-02-14T19:38:44.7420676Z [ RUN      ] MinimalSceneTest.Config
2023-02-14T19:38:44.7421172Z [GUI] [Wrn] [Application.cc:797] [QT] QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-root'
2023-02-14T19:38:44.7421932Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:/qml/StyleDialog.qml:112:3: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
2023-02-14T19:38:44.7422782Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:/qml/StyleDialog.qml:105:3: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
2023-02-14T19:38:44.7423633Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:/qml/StyleDialog.qml:98:3: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
2023-02-14T19:38:44.7424464Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:qml/Main.qml:102:3: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
2023-02-14T19:38:44.7425296Z [GUI] [Wrn] [Application.cc:797] [QT] qrc:/qml/PluginMenu.qml:27:3: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }

@Crola1702 could please look into the GitHub problems for Focal and Jammy and check if they were reported before:

Crola1702 commented 1 year ago

could please look into the GitHub problems for Focal and Jammy and check if they were reported before:

Buildfarmer database doesn't have any record of this test failing

scpeters commented 1 year ago

I've made an alternative attempt in https://github.com/gazebosim/gz-gui/pull/533 and we can see if it has the same test failures

scpeters commented 1 year ago

it looks like the ign-gui6 branch already has these failures in the Jammy CI: